Skip to content

Improve UI/UX in Profiler #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2017
Merged

Improve UI/UX in Profiler #105

merged 3 commits into from
Jun 28, 2017

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Jun 27, 2017

I've added some cool UI features to improve usability in Profiler. ✌️

Select / Deselect all messages

select-deselect-all

Loaders during ajax requests

During sync all

loader-sync

During sync one (thanks to my slow connection 🐢 )

loader-edit

Enjoy ! 🎉

@Nyholm Nyholm self-requested a review June 27, 2017 12:18
Copy link
Contributor

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks great! One minor comment (doesn't block merging it though).

Changelog.md Outdated
@@ -2,6 +2,10 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## Not released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to:

## 0.3.6

.. so we don't have to rename it when releasing.

@welcoMattic
Copy link
Member Author

@rvanlaak Done ;)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@Nyholm Nyholm merged commit af32540 into php-translation:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants